Simplify spilling merge logic in GroupedHashAggregate #12517
+43
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead have extra branches and logic for spill merging we instead just create a new GroupedHashAggregate stream for doing the merge.
|
Thanks -- I am pretty stoked about this type of work @eejbyfeldt I think in general the spilling logic in DataFusion is ok, but could be improved significantly. I am pretty excited to see you starting to make it better. I think it could be easier to read as well as likely be made significantly faster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead have extra branches and logic for spill merging we instead just
create a new GroupedHashAggregate stream for doing the merge.
Which issue does this PR close?
Related to #12335.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?